#115 closed enhancement (fixed)
Unit tests for WP#18158
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Meta/Options | Keywords: | |
| Cc: | bananastalktome@… |
Description
First real unit tests here, so feedback is appreciated. Tests 'NOT EXISTS' compare for metadata. Unit tests for WP:#18158 .
Attachments (1)
Change History (6)
bananastalktome — 10 months ago
Should the users be created explicitly with?
$this->factory->user->create();
- Cc bananastalktome@… added
@scribu This may be an unnecessary check, but I was ensuring that, once the metadata was removed, the same type of assertion from line ~92 (with the 'NOT EXISTS' compare for 'meta_key') would then return that user. Would this be best to leave out of this particular test / is it covered already by other tests?
@kurtpayne Besides the default admin user, a user for this test is already created in the setUp method of Tests_Meta, correct?
Again, I'm new to unit testing and feedback like this is very helpful for me. Thanks!
- Resolution set to fixed
- Status changed from new to closed

Why is this line necessary: