Opened 3 years ago
Closed 14 months ago
#9 closed defect (fixed)
utf8_uri_encode test data includes BOM caused test failure
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | Fix Existing Tests |
| Component: | Test Framework | Keywords: | has-patch |
| Cc: |
Description
From #WP6690. created by nacin.
In WordPress? unit test,
wordpress-tests/wp-testdata/jacob/utf-8.txt
has UTF-8 BOM at the beginning of the file so that testcase
wordpress-tests/wp-testcase/jacob/TestFormatting.php
Test_UTF8_URI_Encode::test_percent_encodes_non_reserved_characters()
fails. Because BOM code (0xef, 0xbb, 0xbf. for UTF-8) is tried to be url encoded.
BOM should not be included in this kind of test data.
You may take out the first 3 bytes from the test file, or UTF-8 compliant editor usually has an option letting you choose whether you use BOM or not for UTF text. I think turn off the option (no BOM) is better in most case.
I confirmed after taking BOM the test case worked fine.
Attachments (2)
Change History (4)
SergeyBiryukov — 14 months ago
comment:1
SergeyBiryukov — 14 months ago
- Keywords has-patch added
- Milestone set to Fix existing Tests
SergeyBiryukov — 14 months ago
comment:2
SergeyBiryukov — 14 months ago
- Resolution set to fixed
- Status changed from new to closed
(In [662]) Use proper encoding for utf-8.txt. fixes #9.