WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 22 months ago

#10 closed defect (fixed)

Correct and make use of TestPluginMenus

Reported by: duck_ Owned by: westi
Milestone: Fix Existing Tests Priority: normal
Component: Test Framework Keywords: has-patch
Cc:

Description

Currently some incorrect assertions for sub menus added to custom top level menus.

_WPEmptyBlog sets the site url to be example.com so we should be able to use that instead of null.host

Also see #WP14159

Attachments (2)

testpluginmenus.diff (5.8 KB) - added by duck_ 3 years ago.
ut.10.diff (793 bytes) - added by duck_ 3 years ago.

Download all attachments as: .zip

Change History (5)

duck_3 years ago

comment:1 duck_3 years ago

[326]

Works great on its own, but noticed that it sometimes fails when run with all other tests. I believe this is because user with ID 1 is deleted at some previous point (so problems with separation of tests) by seeing that var_dump( get_userdata(1) ); is false. Patch attached to make a new administrator user which is deleted at the end of the test instead of relying on user ID 1.

duck_3 years ago

comment:2 nacin22 months ago

Already fixed.

comment:3 nacin22 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.